Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for EasyAudioEncoder (EAE) audio transcoding #165

Merged
merged 25 commits into from
Sep 3, 2022

Conversation

pabloromeo
Copy link
Owner

Adding support for EAE.
The new default is for it to be enabled but if issues occur it can be turned off by setting the environment variable EAE_SUPPORT in the Workers to "false"

Solves #125 and #155

@pabloromeo pabloromeo merged commit 670b6b6 into dev Sep 3, 2022
@pabloromeo
Copy link
Owner Author

@ValZapod, it probably is simpler. However, patching their binary and skipping their licencing most likely breaks their TOS, same with re-distributing their binary separately.
Also, it would be yet another thing to maintain when Plex makes changes to it. By mimicking what Plex already does now the chances are higher for it to be compatible with their next release without making changes each time. The same applies to their other codecs, we download them just as any Plex instance does. But you are right, it is more cumbersome and complex and harder to extend, since Plex isn't open-source and it implies a ton of trial and error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant