Avoid usage of bright_black color #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `OwoColorize::bright_black()` seem to affect a lot of users with dark color schemes as it makes parts of the output unreadable. Avoid the explicit usage of black color and replace all occurrences with a suitable alternate color. Fixes pacak#170
Closed
|
Looks okay on my side as well. I was thinking about adding a third party library to deal with highlighting/colors cheme at some point (#233) but we can release this meanwhile. |
|
Anything else you want to add? If not - I'll merge and release 0.2.26 shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
OwoColorize::bright_black()seem to affect a lot of users with dark color schemes as it makes parts of the output unreadable.Avoid the explicit usage of black color and replace all occurrences with a suitable alternate color.
Fixes #170