Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update testify -> 1.5.1 #178

Merged
merged 1 commit into from
Mar 10, 2020
Merged

update testify -> 1.5.1 #178

merged 1 commit into from
Mar 10, 2020

Conversation

Teelevision
Copy link
Contributor

@Teelevision Teelevision commented Mar 10, 2020 •
edited
Loading

The 1.4.0 version we were using had a bug in the Eventually function that affected the routine package.
stretchr/testify#805

The error showed here: https://travis-ci.org/pace/bricks/builds/660095640

=== RUN   TestRun_cancelsContextAfterRoutineIsFinished
    TestRun_cancelsContextAfterRoutineIsFinished: testing.go:906: race detected during execution of test
--- FAIL: TestRun_cancelsContextAfterRoutineIsFinished (0.01s)

update testify
659cf1d 
The version we were using had a bug in the Eventually function that affected the routine package.
stretchr/testify#805
@Teelevision Teelevision added T::Bug Software bug or design bug (i.e. other than specified) T::Maintainance Refactoring; Better UX/UI; DevOps; Infrastructure; missing documentation labels Mar 10, 2020
@Ferlonas Ferlonas merged commit 8b0dc04 into master Mar 10, 2020
@Ferlonas Ferlonas deleted the update-testify branch March 10, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferlonas Ferlonas Ferlonas approved these changes

Assignees
No one assigned
Labels
T::Bug Software bug or design bug (i.e. other than specified) T::Maintainance Refactoring; Better UX/UI; DevOps; Infrastructure; missing documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teelevision @Ferlonas