Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AbstractConnectionPainter to enable custom connections #437

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

paceholder
Copy link
Owner

No description provided.

Copy link
Contributor

@nolankramer nolankramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far

QPointF const &out = connection.endPoint(PortType::Out);
QPainterPath result(out);

unsigned segments = 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be constexpr, unless you plan for this to be variable?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@paceholder
Copy link
Owner Author

I scoped these changes from the great pull request #386 made by @dine-j

Needed to make a new branch because of changed file names and some fixes in the CI scripts

@paceholder paceholder merged commit 7651465 into master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants