Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Connection Line Arrow #438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add Connection Line Arrow #438

wants to merge 3 commits into from

Conversation

dushibaiyu
Copy link

add Line Arrow and config

@nolankramer
Copy link
Contributor

Thanks for this @dushibaiyu. Would you mind adding a picture to the PR description to show what this looks like during dragging and when connected?

@paceholder
Copy link
Owner

A picture would be really nice. Thanks

@dushibaiyu
Copy link
Author

outArray
inArray
all

@dushibaiyu
Update NodeGraphicsObject.cpp
27c2064 
fix _proxyWidget maybe null
@nolankramer
Copy link
Contributor

nolankramer commented Oct 28, 2024 •
edited
Loading

Thanks @dushibaiyu. So far it looks pretty good. Although two points for improvement:

  • The default arrow-head color should match the default line color
  • It looks like the arrow is not drawn at the head of the line while dragging - this should be fixed before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dushibaiyu @nolankramer @paceholder