Upgrade to React 17, React Leaflet 3.x #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enables trying out selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main driver of this effort is to upgrade React Leaflet to v3.x; see #99 .
React Leaflet 3.x poses some installation problems, as documented in pcic-react-leaflet-components . In this PR we use the working installation documented there.
React Leaflet 3.x requires React 17 as a peer dependency, which in turn requires several other packages to be updgraded, including pcic-react-leaflet-components, react-leaflet, react-select, and react-table. Each of those upgraded packages require a certain amount of work to migrate this project's code.
Finally, there is a peculiarity with
react-leaflet-draw. Its latest release, 0.19.8, is in fact compatible with React Leaflet 3.x and React 17, but itspackage.jsonstates otherwise. Installing it therefore requires annpm install --forcecommand.Also in this PR are a couple of bug fixes:
There is no overall change in the code design, simply changes to details to accommodate upgrades. Several components, but not all, have been converted to hooks to simplify working with them.