Decouple marker radius update from base layer update #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaner, and enables pending spinner on map during marker radius update.
rod-glover
force-pushed
the
marker-radius-spinner
branch
from
ce2c325 to
e99d884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #125
This PR uses React 18 concurrency features to decouple marker radius updates from the basemap updates on zoom.
This solution is simpler and more elegant than the React 17 version (using
setTimeout), and permits us to show a spinner on the map while the radius is being updated.Also shows a map spinner while stations are initially loading.