Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using supported Go versions #50

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

imjasonh
Copy link
Contributor

Go 1.19 and 1.20 are the only currently supported versions. 1.21 will be out soon, at which point 1.19 will no longer be supported.

This might require some behind-the-scenes button-clicking to make the existing checks not required, so this can merge.

@shibumi
Copy link
Collaborator

shibumi commented Jun 28, 2023

@sschuberth looks like we have some permission problem with our Github actions and the branch(?). Any idea how to fix this?

@imjasonh
Copy link
Contributor Author

I think you just need to disable 1.16 and 1.17 as required checks so this can merge, then go back and make 1.19 and 1.20 the required checks for future PRs.

Alternatively you can force-merge this past the required CI checks then change the required checks after this merges.

@shibumi
Copy link
Collaborator

shibumi commented Jun 28, 2023

I think you just need to disable 1.16 and 1.17 as required checks so this can merge, then go back and make 1.19 and 1.20 the required checks for future PRs.

Alternatively you can force-merge this past the required CI checks then change the required checks after this merges.

Yeah, the problem is: I do not have permissions to do this. I have no access to our settings to force-merge this :/

@sschuberth
Copy link
Member

I think you just need to disable 1.16 and 1.17 as required checks so this can merge, then go back and make 1.19 and 1.20 the required checks for future PRs.

Done, will merge.

@sschuberth sschuberth merged commit 584b53a into package-url:master Jun 28, 2023
another-rex referenced this pull request in google/osv-scanner Oct 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/google/go-cmp](https://github.com/google/go-cmp) |
require | minor | `v0.5.9` -> `v0.6.0` |
|
[github.com/jedib0t/go-pretty/v6](https://github.com/jedib0t/go-pretty)
| require | patch | `v6.4.7` -> `v6.4.8` |
|
[github.com/package-url/packageurl-go](https://github.com/package-url/packageurl-go)
| require | patch | `v0.1.1` -> `v0.1.2` |
| golang.org/x/exp | require | digest | `9212866` -> `7918f67` |
| golang.org/x/mod | require | minor | `v0.12.0` -> `v0.13.0` |
| golang.org/x/sync | require | minor | `v0.3.0` -> `v0.4.0` |
| golang.org/x/term | require | minor | `v0.12.0` -> `v0.13.0` |

---

### Release Notes

<details>
<summary>google/go-cmp (github.com/google/go-cmp)</summary>

### [`v0.6.0`](https://github.com/google/go-cmp/releases/tag/v0.6.0)

[Compare
Source](https://github.com/google/go-cmp/compare/v0.5.9...v0.6.0)

New API:

- ([#&#8203;340](https://github.com/google/go-cmp/issues/340)) Add
`cmpopts.EquateComparable`

Documentation changes:

- ([#&#8203;337](https://github.com/google/go-cmp/issues/337)) Use of
hotlinking of Go identifiers

Build changes:

- ([#&#8203;325](https://github.com/google/go-cmp/issues/325)) Remove
purego fallbacks

Testing changes:

- ([#&#8203;322](https://github.com/google/go-cmp/issues/322)) Run
tests for Go 1.20 version
- ([#&#8203;332](https://github.com/google/go-cmp/issues/332)) Pin
GitHub action versions
- ([#&#8203;327](https://github.com/google/go-cmp/issues/327)) set
workflow permission to read-only

</details>

<details>
<summary>jedib0t/go-pretty (github.com/jedib0t/go-pretty/v6)</summary>

###
[`v6.4.8`](https://github.com/jedib0t/go-pretty/releases/tag/v6.4.8)

[Compare
Source](https://github.com/jedib0t/go-pretty/compare/v6.4.7...v6.4.8)

### Features

-   **table**
- `RenderTSV()` to render table in TSV format
([#&#8203;277](https://github.com/jedib0t/go-pretty/issues/277)) //
thanks [@&#8203;rafiramadhana](https://github.com/rafiramadhana)

</details>

<details>
<summary>package-url/packageurl-go
(github.com/package-url/packageurl-go)</summary>

###
[`v0.1.2`](https://github.com/package-url/packageurl-go/releases/tag/v0.1.2)

[Compare
Source](https://github.com/package-url/packageurl-go/compare/v0.1.1...v0.1.2)

#### What's Changed

- Add Julia by [@&#8203;Octogonapus](https://github.com/Octogonapus)
in
[https://github.com/package-url/packageurl-go/pull/44](https://github.com/package-url/packageurl-go/pull/44)
- feat: add missing purl types by
[@&#8203;mcombuechen](https://github.com/mcombuechen) in
[https://github.com/package-url/packageurl-go/pull/43](https://github.com/package-url/packageurl-go/pull/43)
- Pull test data from upstream instead of maintaining a local copy by
[@&#8203;Octogonapus](https://github.com/Octogonapus) in
[https://github.com/package-url/packageurl-go/pull/49](https://github.com/package-url/packageurl-go/pull/49)
- Add simple fuzz test by
[@&#8203;imjasonh](https://github.com/imjasonh) in
[https://github.com/package-url/packageurl-go/pull/34](https://github.com/package-url/packageurl-go/pull/34)
- Test using supported Go versions by
[@&#8203;imjasonh](https://github.com/imjasonh) in
[https://github.com/package-url/packageurl-go/pull/50](https://github.com/package-url/packageurl-go/pull/50)
- Remove deprecated usage of ioutil by
[@&#8203;noqcks](https://github.com/noqcks) in
[https://github.com/package-url/packageurl-go/pull/40](https://github.com/package-url/packageurl-go/pull/40)
- fix: use url.URL to encode and decode PURLs by
[@&#8203;tommyknows](https://github.com/tommyknows) in
[https://github.com/package-url/packageurl-go/pull/52](https://github.com/package-url/packageurl-go/pull/52)
- fix: escape and unescape name by
[@&#8203;tommyknows](https://github.com/tommyknows) in
[https://github.com/package-url/packageurl-go/pull/55](https://github.com/package-url/packageurl-go/pull/55)
- fix: escape everything with modified QueryEscape by
[@&#8203;tommyknows](https://github.com/tommyknows) in
[https://github.com/package-url/packageurl-go/pull/58](https://github.com/package-url/packageurl-go/pull/58)
- Add `pub` and `bitnami` types by
[@&#8203;antgamdia](https://github.com/antgamdia) in
[https://github.com/package-url/packageurl-go/pull/60](https://github.com/package-url/packageurl-go/pull/60)
- Add known types and candidate types by
[@&#8203;antgamdia](https://github.com/antgamdia) in
[https://github.com/package-url/packageurl-go/pull/61](https://github.com/package-url/packageurl-go/pull/61)
- Add PackageURL.Normalize by
[@&#8203;wetterjames4](https://github.com/wetterjames4) in
[https://github.com/package-url/packageurl-go/pull/65](https://github.com/package-url/packageurl-go/pull/65)

#### New Contributors

- [@&#8203;mcombuechen](https://github.com/mcombuechen) made their
first contribution in
[https://github.com/package-url/packageurl-go/pull/43](https://github.com/package-url/packageurl-go/pull/43)
- [@&#8203;imjasonh](https://github.com/imjasonh) made their first
contribution in
[https://github.com/package-url/packageurl-go/pull/34](https://github.com/package-url/packageurl-go/pull/34)
- [@&#8203;noqcks](https://github.com/noqcks) made their first
contribution in
[https://github.com/package-url/packageurl-go/pull/40](https://github.com/package-url/packageurl-go/pull/40)
- [@&#8203;tommyknows](https://github.com/tommyknows) made their first
contribution in
[https://github.com/package-url/packageurl-go/pull/52](https://github.com/package-url/packageurl-go/pull/52)
- [@&#8203;antgamdia](https://github.com/antgamdia) made their first
contribution in
[https://github.com/package-url/packageurl-go/pull/60](https://github.com/package-url/packageurl-go/pull/60)
- [@&#8203;wetterjames4](https://github.com/wetterjames4) made their
first contribution in
[https://github.com/package-url/packageurl-go/pull/65](https://github.com/package-url/packageurl-go/pull/65)

**Full Changelog**:
package-url/packageurl-go@v0.1.1...v0.1.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on monday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/google/osv-scanner).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants