Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3-proxy to use env vars for all secrets #11

Merged
merged 10 commits into from
May 31, 2024

Conversation

paulbarfuss
Copy link

@paulbarfuss paulbarfuss commented May 30, 2024

Changes:

  • Secrets can be set with env vars (flags will still work and take precedence over env vars)
  • Logger configured earlier in init
  • Consistent use of logger, removed fmt.Println where possible
  • Added viperBindEnv() for vars that cannot be set with the viper automatic env vars
  • Implemented Stringer Interface for the Bucket object for debug logging (AccessKeys are visible, SecretKeys are obscured with "*******")
  • Updated golangci-lint version and config
  • Resolved linting issues

Copy link

Hi @paulbarfuss! Add at least one of the required labels to this PR

Required labels are : major, minor, patch

@paulbarfuss paulbarfuss added the patch patch semver label May 30, 2024
@paulbarfuss paulbarfuss added minor minor semver and removed patch patch semver labels May 30, 2024
Copy link

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update all the go dependencies since we're touching this, otherwise looks good.

tylerauerbeck
tylerauerbeck previously approved these changes May 30, 2024
@paulbarfuss paulbarfuss merged commit 1522456 into master May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor semver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants