Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to check for obviously missing components #73

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

ofaurax
Copy link
Contributor

@ofaurax ofaurax commented May 15, 2024

Fix FS-1406

We test if we get at least one Processor and one Disk, for several python versions on several Ubuntu versions.
This means we'll see at test time if data is missing for these 2 components, due to change in tooling affecting all servers.

Signed-off-by: Olivier FAURAX <olivier.faurax@eu.equinix.com>
Signed-off-by: Olivier FAURAX <olivier.faurax@eu.equinix.com>
Copy link

@splaspood splaspood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good... we should probably also add some test to validate the integer vs string issue we had previously.

.github/workflows/ci.yaml Show resolved Hide resolved
@ofaurax
Copy link
Contributor Author

ofaurax commented May 23, 2024

This looks good... we should probably also add some test to validate the integer vs string issue we had previously.

Is this what blocks this PR?

@ofaurax ofaurax merged commit e0ab081 into master May 24, 2024
43 checks passed
@ofaurax ofaurax deleted the add-tests branch May 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants