Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ogr&specfile first; warn user to wait for builds #370

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Move ogr&specfile first; warn user to wait for builds #370

merged 3 commits into from
Aug 23, 2022

Conversation

jpopelka
Copy link
Member

We've installed ogr/specfile/packit from copr repos into packit-service images since packit/packit-service#1616 & packit/packit-service#1619 so before moving the packit-service stable branch (which triggers the images builds) we have to wait for the copr builds to finish (or rebuild the images later).

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 52s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 45s

@jpopelka
Copy link
Member Author

@nforro Do we also want to have a warning to wait with moving packit stable branch after ogr & specfile are built?
(I don't quite understand how packit/specfile#86 prevented packit from being built, so sorry for maybe a silly question.)

@nforro
Copy link
Member

nforro commented Aug 23, 2022

@nforro Do we also want to have a warning to wait with moving packit stable branch after ogr & specfile are built? (I don't quite understand how packit/specfile#86 prevented packit from being built, so sorry for maybe a silly question.)

python3-specfile required python3.6dist(rpm-py-installer), which is not in Fedora/EPEL, and packit buildrequires python3.6dist(specfile), so in turn it buildrequired python3.6dist(rpm-py-installer) as well.

I suppose we should wait, even though such breakage is not very likely to happen again.

@jpopelka
Add whitespace around the correct dash
6768ef4 
I fixed the wrong one in bec0da0
@jpopelka
Move ogr&specfile first; warn user to wait for builds
e3f7168 
We've installed ogr/specfile/packit from copr repos into packit-service images since
packit/packit-service#1616
packit/packit-service#1619
so before moving the packit-service stable branch (which triggers the images builds)
we have wait for the copr builds to finish (or rebuild the images later).
@jpopelka
Better wait for ogr & specfile builds before moving packit
4df74b4 
#370 (comment)
@jpopelka
Copy link
Member Author

Added, PTAL

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 54s

@jpopelka jpopelka added the mergeit When set, zuul wil gate and merge the PR. label Aug 23, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 1m 52s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 288d1b8 into packit:main Aug 23, 2022
@jpopelka jpopelka deleted the move_stable-specific_instructions branch August 23, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nforro nforro nforro approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpopelka @nforro