Utilise default labels and identifier from config for test comment #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed. ✔️ pre-commit SUCCESS in 1m 59s |
nforro
approved these changes
Dec 7, 2023
|
recheck |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 03s |
For /packit test comment command without arguments utilise the values from the configurations. Fixes packit/packit#2056 Merge after packit/packit#2180
lbarcziova
force-pushed
the
default-test-comment-options
branch
from
7b1cd5a to
076eaea
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 59s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 55s |
lbarcziova
added a commit
to lbarcziova/packit.dev
that referenced
this pull request
Dec 7, 2023
Documentation for packit/packit-service#2270 Related to packit/packit#2056
lbarcziova
added a commit
to lbarcziova/packit.dev
that referenced
this pull request
Dec 7, 2023
Documentation for packit/packit-service#2270 Related to packit/packit#2056
lbarcziova
added a commit
to lbarcziova/packit.dev
that referenced
this pull request
Dec 11, 2023
Documentation for packit/packit-service#2270 Related to packit/packit#2056
softwarefactory-project-zuul bot
added a commit
to packit/packit.dev
that referenced
this pull request
Dec 12, 2023
Document new test_command options Documentation for packit/packit-service#2270 Related to packit/packit#2056 Reviewed-by: Nikola Forró Reviewed-by: Laura Barcziová
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
/packit testcomment command without arguments, utilise the values from the configurations.Fixes packit/packit#2056
Merge after packit/packit#2180
TODO:
RELEASE NOTES BEGIN
We have introduced new configuration options
test_command.default_labelsandtest_command.default_identifierthat are used by default when running/packit testcomment command without any arguments (instead of specifying them via--labels/--identifier).RELEASE NOTES END