Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State explicitly where we take the tarball URL #799

Merged
merged 1 commit into from
Jan 9, 2024
Merged

State explicitly where we take the tarball URL #799

merged 1 commit into from
Jan 9, 2024

Conversation

majamassarini
Copy link
Member

No description provided.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/95fee48bc26746b4b10f13fb61fbabbe

✔️ pre-commit SUCCESS in 1m 08s

lbarcziova
lbarcziova reviewed Jan 9, 2024
View reviewed changes
docs/guide.md Outdated
Comment on lines 355 to 357
You don't need to specify the upstream project tarball URL but just the upstream
project repo URL in the Packit configuration file because the tarball URL is taken
from the specfile when needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how relevant is it to the question here 🤔 but I would definitely mention it in the Fedora release guide

nforro
nforro reviewed Jan 9, 2024
View reviewed changes
docs/configuration/index.md Outdated Show resolved Hide resolved
nforro
nforro reviewed Jan 9, 2024
View reviewed changes
docs/guide.md Outdated
Comment on lines 355 to 357
You don't need to specify the upstream project tarball URL but just the upstream
project repo URL in the Packit configuration file because the tarball URL is taken
from the specfile when needed.
Copy link
Member

@nforro nforro Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be here. This section seems to talk about SRPM building.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e67b72a479ac424c9e13f76ec7b3ea67

✔️ pre-commit SUCCESS in 1m 09s

@majamassarini majamassarini force-pushed the upstream-tarball-docs branch from 549b391 to f4f6c74 Compare January 9, 2024 12:49
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ee44011f30764f24b3ad2e601560cf24

❌ pre-commit FAILURE in 59s

@majamassarini
Copy link
Member Author

recheck

lbarcziova
lbarcziova approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/64045389e35f43db8d7fd7e41e73c154

✔️ pre-commit SUCCESS in 1m 11s

@majamassarini @nforro
State explicitly where we take the tarball URL
a544f50 
Co-authored-by: Nikola Forró <nforro@redhat.com>
@majamassarini majamassarini force-pushed the upstream-tarball-docs branch from 3eb869f to a544f50 Compare January 9, 2024 13:39
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/06ea49021b2a4169a9ab69fb11b74928

✔️ pre-commit SUCCESS in 1m 12s

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Jan 9, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0c2d8615f962481e97c24b7e1b4ed876

✔️ pre-commit SUCCESS in 1m 06s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 80e6d41 into packit:main Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nforro nforro nforro approved these changes

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majamassarini @nforro @lbarcziova