Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated section for tests env vars #986

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

thrix
Copy link
Contributor

@thrix thrix commented Jan 8, 2025

It is better for referencing, to have a dedicated and linkable section for these.

It is better for referencing, to have a dedicated and linkable
section for these.

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix
Copy link
Contributor Author

thrix commented Jan 8, 2025

@lbarcziova @mfocko howdy, could we include this pls? It would make linking to this important section a lot easier.

Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Jan 8, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a8a5ae5ede854d0c916477180789f910

✔️ pre-commit SUCCESS in 1m 08s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 87e4b36 into packit:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants