-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPM python bindings dependency #72
Comments
One problem is, specifying A solution that comes to mind is to continue depending on |
how hard would it be to have rpm available on PyPI? would it be too complicated to write a script and run it in GitHub action that would take care of that? |
What do you mean exactly? I don't follow. |
So, I understand that rpm-py-installer compiles the rpm python bindings locally on the fly. That's great but requires all build tools and everything. Since you can have binary artifacts on PyPI, one could do that in a controlled environment (e.g. GitHub action) and upload the artifacts to PyPI as bdist_wheel. Do you think that would work? |
I'm not sure. The thing is, RPM python bindings are tied to a specific RPM version. So there would have to be a build for every RPM version ever released and the correct one would have to be chosen during installation. If I understand it correctly, |
See also rpm-software-management/rpm#273 |
oh, didn't realize it works like that, thank you for educating me I wish they changed their mind. |
A better solution that works with dynamic buildrequires is to substitute %prep
%autosetup -p1 -n specfile-%{version}
sed -i 's/rpm-py-installer/rpm/' setup.cfg
%generate_buildrequires
%pyproject_buildrequires -x testing |
Switch to rpm-py-installer Fixes #72. Reviewed-by: Tomas Tomecek <tomas@tomecek.net>
specfile
currently depends onrpm
which is not (and probably never will be) available on PyPI. That means whoever wants to install it usingpip
has to have RPM python bindings already installed (usually via a package manager).We could instead depend on rpm-py-installer, but it's not a flawless solution.
The text was updated successfully, but these errors were encountered: