Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filenames in source URL fragments #100

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

nforro
Copy link
Member

@nforro nforro commented Sep 12, 2022

Fixes this Sentry issue. Even though the issue is actually caused by a typo in Source0 URL, the typo goes unnoticed by standard tooling because the correct filename is specified in URL fragment.


RELEASE NOTES BEGIN
Added support for filenames specified in source URL fragments, for example: https://example.com/foo/1.0/download.cgi#/%{name}-%{version}.tar.gz
RELEASE NOTES END

Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 35s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 07s
✔️ specfile-tests-pip-deps SUCCESS in 1m 01s

Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I haven't known this syntax exists...

@nforro nforro added the mergeit Zuul, merge it! label Sep 13, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 1m 45s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 91743a5 into main Sep 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the url-fragments branch September 13, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants