Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and optimization #240

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Fixes and optimization #240

merged 4 commits into from
Jun 21, 2023

Conversation

nforro
Copy link
Member

@nforro nforro commented Jun 21, 2023

No description provided.

nforro added 3 commits June 21, 2023 14:06
@nforro
Be explicit about encoding
59bd195 
Default encoding is not always UTF-8, make it explicit. Also use
the surrogateescape error handler to preserve undecodable bytes.

Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Fix a trivial bug in section parsing
28dccf4 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Avoid calling parse() over and over in loops
54a2075 
It turns out that even checking if parsing is necessary or can be
skipped is quite expensive and quickly adds up when performed
in every iteration of a loop. Prevent that and only do it once.

Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/32b54f6cea944737ace3645af60ae526

✔️ pre-commit SUCCESS in 1m 40s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 13s
✔️ specfile-tests-pip-deps SUCCESS in 53s

@nforro
Avoid unnecessary macro expansion
02c888e 
It only makes sense to expand the last token of a section ID line
if it starts with a '%'.

Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Copy link
Member Author

nforro commented Jun 21, 2023

Added one more small optimization.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/161bdbc5af5446e58c303091451e2bfb

✔️ pre-commit SUCCESS in 1m 32s
✔️ specfile-tests-rpm-deps SUCCESS in 53s
✔️ specfile-tests-pip-deps SUCCESS in 50s

@nforro nforro mentioned this pull request Jun 21, 2023
Closed
@nforro
Copy link
Member Author

nforro commented Jun 21, 2023

/packit retest-failed

@nforro
Copy link
Member Author

nforro commented Jun 21, 2023

Rawhide tests will be fixed by https://gitlab.com/testing-farm/gluetool-modules/-/commit/25c51b3983d896d83cbd89a7950d84c8d466d282.

@nforro nforro added the mergeit Zuul, merge it! label Jun 21, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ef29984d2483402c85704c96da612ffc

✔️ pre-commit SUCCESS in 1m 31s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d6b746d into main Jun 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the fixes-and-optimization branch June 21, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit Zuul, merge it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nforro @jpopelka