Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failures when creating dummy sources #271

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

nforro
Copy link
Member

@nforro nforro commented Aug 9, 2023

This makes it possible to parse a spec file on a read-only filesystem for instance. At the cost of potentially incorrectly parsed %prep in case some sources are missing.

Related to fedora-copr/copr#2839.

RELEASE NOTES BEGIN

specfile no longer tracebacks when some sources are missing and can't be emulated. In such case the spec file is parsed without them at the cost of %setup and %patch macros potentially expanding differently than with the sources present.

RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2c59bd75d6ec430da7bfb8dd0b6853f5

✔️ pre-commit SUCCESS in 1m 26s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 04s
✔️ specfile-tests-pip-deps SUCCESS in 1m 01s

specfile/spec_parser.py Show resolved Hide resolved
Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/64b3dbb07fdd4723b9950364233b7242

✔️ pre-commit SUCCESS in 1m 33s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 11s
✔️ specfile-tests-pip-deps SUCCESS in 1m 10s

@nforro nforro added the mergeit Zuul, merge it! label Aug 11, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0ce85af0d3b74f2995e228ed40cf876c

✔️ pre-commit SUCCESS in 1m 28s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9f0e79c into main Aug 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the dummy-sources branch August 11, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants