Make Sources inherit from MutableSequence #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to actually iterate through sources without having to implement __iter__(). Also, other methods like append() or clear() are already implemented in MutableSequence. __contains__(), remove() and count() remain reimplemented as they allow to perform the actions by location. Signed-off-by: Nikola Forró <nforro@redhat.com>
Merged
|
Build failed.
|
FrNecas
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to actually iterate through sources without having to implement
__iter__().Also, other methods like
append()orclear()are already implemented inMutableSequence.__contains__(),remove()andcount()remain reimplemented as they allow to perform the actions by location.