Process seemingly commented-out macro definitions correctly #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may seem that `#%global prerel rc1` is a commented-out macro definition, however as the `%` is not escaped it is still being evaluated and the `prerel` macro becomes defined. Macro definitions like this are now parsed correctly, having the `commented_out` attribute set to `False`. Signed-off-by: Nikola Forró <nforro@redhat.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 14s |
|
/packit test |
|
/packit-stg test |
|
/packit test |
|
/packit-stg test |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 20s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may seem that
#%global prerel rc1is a commented-out macro definition, however as the%is not escaped it is still being evaluated and theprerelmacro becomes defined.Macro definitions like this are now parsed correctly, having the
commented_outattribute set toFalse.