Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unparseable %changelog lines when checking for %autochangelog #387

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Jun 24, 2024

Fixes #386.

RELEASE NOTES BEGIN

Fixed an exception that occured when accessing the Specfile.has_autochangelog property while having unparseable lines (e.g. lines ending with unescaped %) in %changelog.

RELEASE NOTES END

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d3527cb6475940c4b6a8e411ee650984

✔️ pre-commit SUCCESS in 2m 30s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 33s
✔️ specfile-tests-pip-deps SUCCESS in 1m 13s

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Nikola Forró <nforro@redhat.com>
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/59a588abccb246f49e36095646877ed7

✔️ pre-commit SUCCESS in 2m 19s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 24s
✔️ specfile-tests-pip-deps SUCCESS in 1m 23s

@nforro nforro added the mergeit Zuul, merge it! label Jun 24, 2024
@nforro
Copy link
Member Author

nforro commented Jun 24, 2024

regate

@nforro nforro added mergeit Zuul, merge it! and removed mergeit Zuul, merge it! labels Jun 24, 2024
@nforro
Copy link
Member Author

nforro commented Jun 24, 2024

regate

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4e49a3871dd94027bd9ecda2d58651e2

✔️ pre-commit SUCCESS in 2m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6137959 into main Jun 24, 2024
28 checks passed
@nforro nforro deleted the autochangelog branch June 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packit fails with UnterminatedMacroException if %changelog contains % charater
2 participants