Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and improvements #69

Merged
merged 8 commits into from
Jul 22, 2022
Merged

Various fixes and improvements #69

merged 8 commits into from
Jul 22, 2022

Conversation

nforro
Copy link
Member

@nforro nforro commented Jul 20, 2022

A bunch of fixes and improvements mostly based on feedback from packit/packit#1588

updates:
- [github.com/asottile/pyupgrade: v2.32.1 → v2.37.1](asottile/pyupgrade@v2.32.1...v2.37.1)
- [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0)
- [github.com/pre-commit/mirrors-prettier: v2.6.2 → v2.7.1](pre-commit/mirrors-prettier@v2.6.2...v2.7.1)
- [github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0](pre-commit/pre-commit-hooks@v4.2.0...v4.3.0)
- [github.com/pre-commit/mirrors-mypy: v0.960 → v0.961](pre-commit/mirrors-mypy@v0.960...v0.961)
@nforro nforro requested a review from FrNecas July 20, 2022 09:02
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 2m 32s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 46s
✔️ specfile-tests-pip-deps SUCCESS in 2m 11s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 42s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 13s
✔️ specfile-tests-pip-deps SUCCESS in 1m 12s

Copy link
Contributor

@FrNecas FrNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few suggestions

tests/unit/test_sources.py Outdated Show resolved Hide resolved
specfile/sources.py Outdated Show resolved Hide resolved
specfile/tags.py Show resolved Hide resolved
nforro added 2 commits July 21, 2022 13:50
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 2m 00s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 08s
✔️ specfile-tests-pip-deps SUCCESS in 1m 02s

nforro added 5 commits July 21, 2022 16:29
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 53s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 31s
✔️ specfile-tests-pip-deps SUCCESS in 1m 39s

Copy link
Contributor

@FrNecas FrNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the improvements, looks good now!

@nforro nforro added the mergeit Zuul, merge it! label Jul 21, 2022
@FrNecas FrNecas mentioned this pull request Jul 21, 2022
@nforro nforro added mergeit Zuul, merge it! and removed mergeit Zuul, merge it! labels Jul 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

pre-commit NODE_FAILURE in 0s

@nforro nforro added mergeit Zuul, merge it! and removed mergeit Zuul, merge it! labels Jul 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

pre-commit NODE_FAILURE in 0s

@nforro nforro added mergeit Zuul, merge it! and removed mergeit Zuul, merge it! labels Jul 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

pre-commit NODE_FAILURE in 0s

@nforro nforro merged commit ac1113f into main Jul 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the nforro-misc branch July 22, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants