-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and improvements #69
Conversation
updates: - [github.com/asottile/pyupgrade: v2.32.1 → v2.37.1](asottile/pyupgrade@v2.32.1...v2.37.1) - [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0) - [github.com/pre-commit/mirrors-prettier: v2.6.2 → v2.7.1](pre-commit/mirrors-prettier@v2.6.2...v2.7.1) - [github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0](pre-commit/pre-commit-hooks@v4.2.0...v4.3.0) - [github.com/pre-commit/mirrors-mypy: v0.960 → v0.961](pre-commit/mirrors-mypy@v0.960...v0.961)
Build succeeded. ✔️ pre-commit SUCCESS in 2m 32s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 42s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few suggestions
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Build succeeded. ✔️ pre-commit SUCCESS in 2m 00s |
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the improvements, looks good now!
Build failed (gate pipeline). ❌ pre-commit NODE_FAILURE in 0s |
Build failed (gate pipeline). ❌ pre-commit NODE_FAILURE in 0s |
Build failed (gate pipeline). ❌ pre-commit NODE_FAILURE in 0s |
A bunch of fixes and improvements mostly based on feedback from packit/packit#1588