Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow react v19 as peer dep #318

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

Yonom
Copy link
Contributor

@Yonom Yonom commented Oct 22, 2024

I get the following warning from pnpm after upgrading to NextJS v15 (released today), which installs react 19 RC

React 19 is technically still in RC stage, but since a stable version of a major Metaframework is installing it, it's a sign that it's ready for production use and will now be used by many projects.

│ ├─┬ cmdk 1.0.0
│ │ ├── ✕ unmet peer react@^18.0.0: found 19.0.0-rc-65a56d0e-20241020
│ │ ├── ✕ unmet peer react-dom@^18.0.0: found 19.0.0-rc-65a56d0e-20241020

P.S.: thank you so much for this package! it has been a big source of inspiration for my project (radix UI for AI chat interfaces)

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ❌ Failed (Inspect) Oct 22, 2024 0:21am

@DysektAI
Copy link

Can we get an update? I really hate overriding, if possible it would be nice to get this updated asap.

Copy link

@programORdie2 programORdie2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect (the test failed because of an outdated lockfile)

@shimizudev
Copy link

less gooo

@pacocoursey pacocoursey merged commit 06e9cb6 into pacocoursey:main Oct 30, 2024
1 of 3 checks passed
@Yonom Yonom deleted the react-19 branch October 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants