chore: mark pactffi_logger_attach_sink as unsafe #148

pact-foundation · Sep 24, 2021 · 40cf1ab · 40cf1ab
1 parent ab89152
commit 40cf1ab
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/rust/pact_ffi/src/log/ffi.rs b/rust/pact_ffi/src/log/ffi.rs
@@ -31,7 +31,7 @@ pub extern "C" fn pactffi_log_to_stdout(level_filter: LevelFilter) -> c_int {
         }
     };
 
-    let status = pactffi_logger_attach_sink(spec.as_ptr(), level_filter);
+    let status = unsafe { pactffi_logger_attach_sink(spec.as_ptr(), level_filter) };
     if status != 0 {
         return status;
     }
@@ -57,7 +57,7 @@ pub extern "C" fn pactffi_log_to_stderr(level_filter: LevelFilter) -> c_int {
         }
     };
 
-    let status = pactffi_logger_attach_sink(spec.as_ptr(), level_filter);
+    let status = unsafe { pactffi_logger_attach_sink(spec.as_ptr(), level_filter) };
     if status != 0 {
         return status;
     }
@@ -134,7 +134,7 @@ pub extern "C" fn pactffi_log_to_buffer(level_filter: LevelFilter) -> c_int {
     }
   };
 
-  let status = pactffi_logger_attach_sink(spec.as_ptr(), level_filter);
+  let status = unsafe { pactffi_logger_attach_sink(spec.as_ptr(), level_filter) };
   if status != 0 {
     return status;
   }
@@ -228,12 +228,12 @@ pub extern "C" fn pactffi_logger_init() {
 #[allow(clippy::missing_safety_doc)]
 #[allow(clippy::not_unsafe_ptr_arg_deref)]
 #[no_mangle]
-pub extern "C" fn pactffi_logger_attach_sink(
+pub unsafe extern "C" fn pactffi_logger_attach_sink(
     sink_specifier: *const c_char,
     level_filter: LevelFilter,
 ) -> c_int {
     // Get the specifier from the raw C string.
-    let sink_specifier = unsafe { CStr::from_ptr(sink_specifier) };
+    let sink_specifier = CStr::from_ptr(sink_specifier);
     let sink_specifier = match sink_specifier.to_str() {
         Ok(sink_specifier) => sink_specifier,
         // TODO: Permit non-UTF8 strings, as some filesystems may have non-UTF8