Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged removeDefaultHeader and removeDefaultHeaders methods into one #366

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Merged removeDefaultHeader and removeDefaultHeaders methods into one #366

merged 3 commits into from
Jul 20, 2024

Conversation

raj356
Copy link
Contributor

@raj356 raj356 commented Jul 20, 2024 •
edited
Loading

Hi @ASaiAnudeep , the following changes are for Issue #365

Done the following:

  1. Have merged removeDefaultHeader and removeDefaultHeaders into one method removeDefaultHeaders
  2. If key is mentioned it will delete the particular default header else if nothing is mentioned will delete all the default
    headers
  3. Have removed one unit test due to the current changes, as now based on the truthiness of the key we are deciding what
    action to be performed
  4. Have added 2 unit tests
  5. Added the doc for removeDefaultHeaders, PR link - added doc for removeDefaultHeaders pactumjs.github.io#52

Please review the changes and do the needful. Thanks!

@ASaiAnudeep ASaiAnudeep merged commit a9fe231 into pactumjs:master Jul 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASaiAnudeep ASaiAnudeep ASaiAnudeep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raj356 @ASaiAnudeep