Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url): normalizeURL wasn't working on https with .git suffix #176

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Alan-pad
Copy link
Contributor

@Alan-pad Alan-pad commented Oct 16, 2023

Closes #173

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #176 (f089c51) into main (f6a0806) will increase coverage by 0.41%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   69.02%   69.44%   +0.41%     
==========================================
  Files          28       29       +1     
  Lines        2034     2042       +8     
==========================================
+ Hits         1404     1418      +14     
+ Misses        545      541       -4     
+ Partials       85       83       -2     
Files Coverage Δ
internal/utils/url/url.go 100.00% <100.00%> (ø)
internal/webhook/event/common.go 53.33% <ø> (+7.50%) ⬆️
internal/webhook/event/pullrequest.go 81.94% <100.00%> (ø)
internal/webhook/event/push.go 54.05% <100.00%> (ø)
internal/webhook/github/provider.go 69.64% <100.00%> (ø)
internal/webhook/gitlab/provider.go 75.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alan-pad Alan-pad force-pushed the fix/normalize-url-173 branch from a85eadf to f089c51 Compare October 23, 2023 08:25
@Alan-pad Alan-pad force-pushed the fix/normalize-url-173 branch from f089c51 to 858fc21 Compare November 13, 2023 15:17
@Alan-pad Alan-pad merged commit 5dfe71c into main Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: normalizeURL doesn't work on https://<URL>.git
2 participants