Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): correctly handle PR events #184

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(github): correctly handle PR events #184

merged 1 commit into from
Nov 6, 2023

Conversation

corrieriluca
Copy link
Member

@corrieriluca corrieriluca commented Nov 4, 2023

Fixes #186

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #184 (9d4db5a) into main (983ad07) will decrease coverage by 0.08%.
The diff coverage is 55.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   68.93%   68.86%   -0.08%     
==========================================
  Files          28       28              
  Lines        2025     2033       +8     
==========================================
+ Hits         1396     1400       +4     
- Misses        545      549       +4     
  Partials       84       84              
Files Coverage Δ
internal/webhook/github/provider.go 67.18% <55.55%> (-2.46%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@corrieriluca corrieriluca force-pushed the fix/github-pr branch 7 times, most recently from f29a544 to 7de778c Compare November 5, 2023 16:33
@corrieriluca corrieriluca marked this pull request as ready for review November 5, 2023 16:54
@corrieriluca corrieriluca requested a review from Alan-pad November 5, 2023 16:57
@Alan-pad Alan-pad merged commit 511b84a into main Nov 6, 2023
4 of 5 checks passed
@corrieriluca corrieriluca deleted the fix/github-pr branch November 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treating a PR reopening as a PR opening
3 participants