Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controllers): reconcile on annotation update #188

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

corrieriluca
Copy link
Member

Breaking changes

  • All controllers: reconcile when annotations change
    • Previously the update predicate was ignoring all changes applied to a resource apart from its spec.
    • Burrito relying heavily on annotations to trigger changes on its resources, I find it useful to reconcile upon annotation changes.
    • ⚠️ Note that this can have unintended side-effect. I made that change initially for triggering a re-sync on layers when their LastRelevantCommit changes (e.g. when a Push event is received by the Webhook).

@codecov-commenter
Copy link

Codecov Report

Merging #188 (5e45650) into main (983ad07) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   68.93%   68.43%   -0.51%     
==========================================
  Files          28       28              
  Lines        2025     2040      +15     
==========================================
  Hits         1396     1396              
- Misses        545      560      +15     
  Partials       84       84              
Files Coverage Δ
internal/controllers/terraformlayer/controller.go 35.52% <0.00%> (-2.51%) ⬇️
...nal/controllers/terraformpullrequest/controller.go 32.35% <0.00%> (-2.57%) ⬇️
internal/controllers/terraformrun/controller.go 59.61% <0.00%> (-3.02%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Alan-pad Alan-pad marked this pull request as ready for review November 9, 2023 14:48
@Alan-pad Alan-pad merged commit b8f373f into main Nov 9, 2023
4 of 5 checks passed
@corrieriluca corrieriluca deleted the fix/reconcile-annotations branch November 9, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants