feat: make drift check and apply with custom runner code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoukke
commented
Dec 5, 2022
spoukke
commented
Dec 5, 2022
| c.Status.Message = "Terraform has not ran yet" | ||
| return status | ||
| } | ||
| if string(result) == "1" { |
There was a problem hiding this comment.
maybe change the key to terraformExiteGracefully and have a bool instead ?
spoukke
commented
Dec 5, 2022
spoukke
force-pushed
the
feat/initial-crds
branch
from
1de868e to
4a993ae
Compare
spoukke
commented
Dec 20, 2022
| "errors" | ||
| ) | ||
|
|
||
| type MemoryCache struct { |
There was a problem hiding this comment.
Memorycache is only useful for testing purposes. It should be a Mock inside the controller package
There was a problem hiding this comment.
Don't you think it could be used in the runner package for testing purposes ?
This was
linked to
issues
Dec 22, 2022
spoukke
changed the title
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.