Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): use search parameters when filtering #222

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

declement
Copy link
Contributor

@declement declement commented Jan 18, 2024

Description

This PR makes use of URL search parameters for filtering layers in the UI. It provides better sharable links.

Fixes #216

@declement declement requested a review from Alan-pad January 18, 2024 13:17
Copy link
Contributor

@marcantoinegodde marcantoinegodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great code ! :)

Shouldn't we also include the hidePRFilter in the path parameters ? As it actually changes the result of the request (not like the grid/table buttons), it might make sense. What is your opinion ?

@declement
Copy link
Contributor Author

I agree, I didn't see this one. I will also add a new search parameter for hidePRFilter.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4eb97de) 69.45% compared to head (e289a8a) 69.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   69.45%   69.45%           
=======================================
  Files          29       29           
  Lines        2089     2089           
=======================================
  Hits         1451     1451           
  Misses        556      556           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alan-pad Alan-pad merged commit 5d39b2e into main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Integrate filters (search, repo, state) into the URL
4 participants