-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runner): refactor runner + use tenv to install binaries #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrieriluca
force-pushed
the
feat/refacto-runner
branch
from
August 21, 2024 10:48
c1db3fa
to
c2202a7
Compare
LucasMrqes
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, the new structure is great and the runner test framework is super useful.
The new logs are also very useful, we might add more events on tfl / tfr resources as well to ease debugging
I cannot get tests to run locally though, but it is probably an issue on my end.
Alan-pad
force-pushed
the
feat/refacto-runner
branch
from
September 2, 2024 14:23
564a1ae
to
5a78e3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tenv
Go module to improve downloads of Terraform/Terragrunt:latest-allowed
strategy will be the default (tenv
finds the most compatible version from version constraints set in codebase)terraform.version
andterragrunt.version
fields are still present and allow for more complex version constraints such as~> 1.4
or>= 0.66.0
(everything allowed by HCL)