Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): refactor runner + use tenv to install binaries #319

Merged
merged 18 commits into from
Sep 2, 2024

Conversation

corrieriluca
Copy link
Member

@corrieriluca corrieriluca commented Aug 20, 2024

  • Refactored runner code in several functions and files to improve readability and testability
  • Wrote tests for the runner package (E2E tests as well as more scoped ones) => (~45% code coverage)
  • Introduced the tenv Go module to improve downloads of Terraform/Terragrunt:
    • Specifying tools' versions in TerraformRepository or TerraformLayer is no longer mandatory, the latest-allowed strategy will be the default (tenv finds the most compatible version from version constraints set in codebase)
    • The terraform.version and terragrunt.version fields are still present and allow for more complex version constraints such as ~> 1.4 or >= 0.66.0 (everything allowed by HCL)
  • Updated documentation accordingly

@corrieriluca corrieriluca marked this pull request as ready for review August 22, 2024 09:31
Copy link
Collaborator

@LucasMrqes LucasMrqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, the new structure is great and the runner test framework is super useful.
The new logs are also very useful, we might add more events on tfl / tfr resources as well to ease debugging
I cannot get tests to run locally though, but it is probably an issue on my end.

cmd/runner/start.go Outdated Show resolved Hide resolved
internal/runner/actions.go Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
@Alan-pad Alan-pad force-pushed the feat/refacto-runner branch from 564a1ae to 5a78e3c Compare September 2, 2024 14:23
@Alan-pad Alan-pad merged commit f347b55 into main Sep 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants