feat: set default runner image in global config #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 50.99% 50.99%
=======================================
Files 73 73
Lines 4334 4334
=======================================
Hits 2210 2210
Misses 1935 1935
Partials 189 189 ☔ View full report in Codecov by Sentry. |
corrieriluca
approved these changes
Oct 25, 2024
cmd/controllers/start.go
Outdated
Comment on lines
46
to
48
| cmd.Flags().StringVar(&app.Config.Runner.Image.Repository, "runner-image-repository", "ghcr.io/padok-team/burrito-runner", "Repository of the image to use for the runner pods created by the controller") | ||
| cmd.Flags().StringVar(&app.Config.Runner.Image.Tag, "runner-image-tag", version.Version, "Tag of the image to use for the runner pods created by the controller") | ||
| cmd.Flags().StringVar(&app.Config.Runner.Image.PullPolicy, "runner-image-pull-policy", string(corev1.PullIfNotPresent), "Pull policy of the image to use for the runner pods created by the controller") |
There was a problem hiding this comment.
Is it really necessary to expose those options as CLI flags?
If I remember correctly, not every config option is exposed as a flag in Burrito
There was a problem hiding this comment.
You're right, this is useless I'm removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a configuration parameter to set the default repository, tag, and pull policy for the image used in runner pods.
Previously, to use a custom image for all Burrito pods (often necessary during development), we had to override the image in both the chart's values and the spec.overrideRunnerSpec field of a TerraformLayer or TerraformRepository resource.