Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checks): Add checks on CloudFunctions #42

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

corrieriluca
Copy link
Member

@corrieriluca corrieriluca commented Oct 20, 2023

  • GCP_FUN_001: All cloud functions are private (ingress settings != Allow all traffic)
  • GCP_FUN_002: Cloud functions does not use the default compute engine service account
  • GCP_FUN_003: Cloud functions does not have sensitive plain variables (use secret instead!)
  • GCP_FUN_004: All cloud functions require authentication (IAM)

Misc

This PR also fixes #44

@corrieriluca corrieriluca changed the title feat(functions): Add checks on CloudFunctions feat(checks): Add checks on CloudFunctions Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@8f05792). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage        ?   17.16%           
=======================================
  Files           ?       13           
  Lines           ?      600           
  Branches        ?        0           
=======================================
  Hits            ?      103           
  Misses          ?      493           
  Partials        ?        4           
Files Coverage Δ
gcp/gcs/getter.go 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@@ -33,6 +33,7 @@ func GetCloudRunServices(account internal.GCPAccount) []runpb.Service {
}
if err != nil {
logger.Logger.Error("Failed to list CloudRun services", "error", err.Error())
break
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #44

@corrieriluca corrieriluca force-pushed the feat/cloud_functions_implementation branch from 0536b44 to a46304a Compare November 3, 2023 16:23
@corrieriluca corrieriluca marked this pull request as ready for review November 3, 2023 16:32
@corrieriluca corrieriluca merged commit ae66ee4 into main Nov 3, 2023
2 checks passed
@corrieriluca corrieriluca deleted the feat/cloud_functions_implementation branch November 3, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YATAS scan not running when Cloud Run API not enabled
3 participants