Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change music settings labels #90

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

DayKev
Copy link
Contributor

@DayKev DayKev commented Dec 29, 2024

Changes in settings.json.

Old:

  • "consistent": "Consistent"
  • "mixed": "Mixed"

New:

  • "musicGenFive": "Gen V + PMD"
  • "musicAllGens": "All Gens"

settings:mixed removed entirely as it is no longer used.

@DayKev
Copy link
Contributor Author

DayKev commented Dec 29, 2024

Hold on, I've been made aware that it's "Gen 5 + PMD" and not just Gen 5, lemme fix it rq.

Edit: Done.

@DayKev DayKev marked this pull request as ready for review December 29, 2024 09:35
Copy link
Contributor

@CodeTappert CodeTappert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sadly i can not merge it

@Adri1 Adri1 merged commit a60675e into pagefaultgames:main Dec 30, 2024
1 check passed
@DayKev DayKev deleted the change-music-settings-labels branch December 31, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants