[Move] Tera Blast Added Ability To Ignore Held Items And Abilities During Stat Calculation #4984
+82
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
There are no superficial changes.
What are the changes from a developer perspective?
I added the variable
ignoreHeldItems: boolean = false
togetEffectiveStat()
in order to skip held items during the effective stats calculation.Also added ability ignore and held items ignore parameter in
TeraMoveCategoryAttr
so abilities and held items are properly ignored.Added tests to
tera_blast.test.ts
to check if my implementation works properly and some more.Removed
.partial()
Screenshots/Videos
No Visual changes are available but I have screenshots of my console (I added some
console.log
comments)Cubone: ATK: 10, SPATK: 11, Held Items: Thick Club (Doubles Cubone's ATK)
Before Implementation:
After Implementation:
(Automated tests cover the same for abilities instead of held items)
How to test the changes?
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?