Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Item] Add Deep Sea Scale & Deep Sea Tooth items #5078

Open
wants to merge 8 commits into
base: beta
Choose a base branch
from

Conversation

Madmadness65
Copy link
Collaborator

@Madmadness65 Madmadness65 commented Jan 4, 2025

What are the changes the user will see?

Adds the Deep Sea Scale and Deep Sea Tooth species-specific items for Clamperl in the Great tier, which also comes with an evolution method change for it to no longer be gender-specific, but instead require one of the Deep Sea items to be held before using a Linking Cord.

Why am I making these changes?

Clamperl's special boosting items were wanted like the other species-specific held items, they just needed a bit more added to it so they could function as part of its evolution too. I am aware that this increases the difficulty in evolving Clamperl, but the boosts the Deep Sea items give, alongside other niche items like Eviolite, and the Deep Sea items specifically being in the Great tier, I feel make up for the additional time spent finding the second item.

What are the changes from a developer perspective?

Two new entries in the SpeciesStatBoosterItem list for Deep Sea Scale and Deep Sea Tooth, as well as Clamperl's evolution condition being changed to requiring an instance of one of the Deep Sea items. Species stat booster items have been split between regular in the Great item pool (currently just the Deep Sea Scale and Tooth) and rare in the Ultra item pool (everything else, unchanged from a player's perspective). This should not affect any existing species stat booster items in existing save files.

Screenshots/Videos

deepsea.mp4

How to test the changes?

Change the item reward override to either [{name: "SPECIES_STAT_BOOSTER", type: "DEEP_SEA_SCALE"}, {name: "EVOLUTION_ITEM", type: 1}] or [{name: "SPECIES_STAT_BOOSTER", type: "DEEP_SEA_TOOTH"}, {name: "EVOLUTION_ITEM", type: 1}]. Clamperl will not be able to use a Linking Cord until it has one of the Deep Sea items.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    - [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

Also changes Clamperl's evolution method from gender-specific to requiring one of the Deep Sea items to be held.
@Madmadness65 Madmadness65 added the Item Affects an item label Jan 4, 2025
@Madmadness65 Madmadness65 requested a review from a team as a code owner January 4, 2025 04:33
@DayKev DayKev added the Enhancement New feature or request label Jan 7, 2025
@Blitz425
Copy link
Contributor

Would like for the items to be made Great tier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Item Affects an item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants