Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent/unreliable language indexing #102

Closed
mbrodala opened this issue Nov 22, 2023 · 0 comments · Fixed by #110
Closed

Inconsistent/unreliable language indexing #102

mbrodala opened this issue Nov 22, 2023 · 0 comments · Fixed by #110

Comments

@mbrodala
Copy link
Member

The indexing (in particular: preview rendering) of anything besides the default language is inconsistent and unreliable.

The IndexService adjusts the locale/language for BE/CLI context just fine. However, the TsfeUtility sets up a simulated frontend which automatically picks the first site and its default language. This ignores the language for the current indexing run which may be a different one.

Given that the existing logic is already way too complex and hard to manage, a rewrite from scratch should be considered. Options:

  1. Set up a middleware or similar which is called via HTTP for preview rendering
  2. Use a sub request for a proper frontend request for preview rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant