Support site and site languages per indexer #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
force-pushed
the
indexer-site
branch
from
7c452af to
bda7382
Compare
This will allow us to set up frontend aspects like the site and language in following changes once per indexer. Previously this did happen intransparently on the first usage of the OverlayUtility with no way to adjust the TSFE setup here.
mbrodala
force-pushed
the
indexer-site
branch
3 times, most recently
from
3db6c51 to
4a32386
Compare
mbrodala
changed the title
We now look up the site language for the current index language. This finally ensures a consistent and predictable translation behavior. The tests must be adjusted since they did in fact work with an invalid setup.
mbrodala
force-pushed
the
indexer-site
branch
from
4a32386 to
ca0c1f1
Compare
While technically correct we should not fail hard in this case. The fallback to the site default language basically restores the old behavior in this case. A proper fix would be excluding indexers from index languages or configuring the languages supported by an indexer. But this is beyond the scope of the current topic.
mbrodala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among others fixes #102