Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TYPO3v10 support #13

Merged
merged 26 commits into from
Sep 17, 2020
Merged

Add TYPO3v10 support #13

merged 26 commits into from
Sep 17, 2020

Conversation

mbrodala
Copy link
Member

No description provided.

@mbrodala mbrodala force-pushed the typo3v10 branch 15 times, most recently from 569f74d to 490ff68 Compare September 17, 2020 07:38
@mbrodala mbrodala marked this pull request as ready for review September 17, 2020 09:50
@mbrodala mbrodala force-pushed the typo3v10 branch 2 times, most recently from a06d274 to 7f38c04 Compare September 17, 2020 10:16
@mbrodala
[TASK] Allow installation with TYPO3v10
56031db
@mbrodala
[TASK] Build against TYPO3v10
abbed52
@mbrodala
[TASK] Replace deprecated $GLOBALS['TSFE']->sys_language_uid access
36d7d1b 
See https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.4/Deprecation-85543-Language-relatedPropertiesInTypoScriptFrontendControllerAndPageRepository.html
And https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.0/Breaking-87193-DeprecatedFunctionalityRemoved.html
@mbrodala
[TASK] Ignore cross-version errors in PHPStan
bda6c33
@mbrodala
[BUGFIX] Fix failing TcaDataCollector unit test
cc1646f 
The ObjectManager requires native dependency injection now so make sure
we always use a mock in tests.
@mbrodala
[TASK] Reduce usage of $_EXTKEY
e3af625
@mbrodala
[TASK] Use own response object
c09faa5 
See https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5/Deprecation-84196-BackendControllerActionsDoNotReceivePreparedResponse.html
And https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.0/Breaking-87193-DeprecatedFunctionalityRemoved.html
@mbrodala
[TASK] Move webserver for functional testing to a trait
d7ab78c
@mbrodala
[BUGFIX] Wait for webserver to be ready
cc58e4a 
See symfony/symfony#30025 (comment)
@mbrodala
[BUGFIX] Forward prepared TYPO3_* env variables to webserver
c3ee6dd 
This is essential for the checks in
SystemEnvironmentBuilder::initializeEnvironment() where TYPO3_PATH_ROOT
and TYPO3_PATH_APP must be properly related to each other. These are
defined in AbstractTestSystem::setTypo3Context() and involve some
processing.

With this the config/var path is always the same both for the test
itself as well as the website accessed by the temporary webserver.
@mbrodala
[TASK] Add middleware for URI building in TYPO3v9+
fa570f8 
This adds a handler for "/-/searchable/urls" urls which expects a list
of Typolink configurations and returns resolved links.
@mbrodala
[TASK] Set slugs in indexing test for TYPO3v9+
cdd8de2
@mbrodala
[TASK] Skip EidUtility usage if absent in TYPO3v10+
f2c1d98 
See https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.4/Deprecation-85878-EidUtilityAndVariousTSFEMethods.html
And https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.0/Breaking-87193-DeprecatedFunctionalityRemoved.html?highlight=eidutil
@mbrodala
[TASK] Skip TSFE simulation for record overlays in TYPO3v10+
9669869
@mbrodala
[TASK] Drop logging from functional test webserver
072e1b9 
For some reason the log file handle is missing sometimes leading to
failing fwrite() calls in FileWriter. Thus drop this completely for now.
@mbrodala
[BUGFIX] Properly create SiteConfiguration in TYPO3v9
631c08e 
Only in TYPO3v10+ dependency injection takes care of passing the
required constructor argument.
@mbrodala
[BUGFIX] Explicitly stop webserver again
d716df8
@mbrodala
[BUGFIX] Update expected links in test for TYPO3v9+
0c70ed7
@mbrodala
[TASK] Use cross-version setup for sites in tests again
d1c6a79 
Unfortunately SiteConfiguration::createBasicSite() was added with
TYPO3v10 so we need to stick to the basic variant of the testing
framework instead.
@mbrodala
[BUGFIX] Fix TSFE booting for TYPO3v9
34c273f
@mbrodala
[TASK] Merge AbstractEidLinkBuilder into AbstractLinkBuilder
a15355b
@mbrodala
[TASK] Use middleware for link building in TYPO3v9+
27691d3
@mbrodala
[TASK] Skip title when building links
80b1558 
Since we are actually building URIs and not links here, there is no
point in passing around an unused title here.
@mbrodala
[BUGFIX] Flush site configuration caches in TYPO3v9+
d87ce48
@mbrodala
[BUGFIX] Always return integer in language ID trait
d53d86d 
For TYPO3v8 and within an eID search we must make sure to use the
default language if nothing can be determined otherwise.
@mbrodala
[TASK] Ignore extension scanner match for command controller
b0bbb02 
This controller is explicitly kept around for TYPO3v8 support.
@mbrodala mbrodala merged commit 6af539d into master Sep 17, 2020
@mbrodala mbrodala deleted the typo3v10 branch September 17, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbrodala