Use site fallback for links on TYPO3v10 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
force-pushed
the
typo3v10-links-site
branch
from
79cee6e to
eba585b
Compare
In case no site could be resolved in the link building request (e.g. if a development host is used not covered by site config), we now fall back to the first site. This basically reflects the PseudoSite handling which was dropped with TYPO3v10 which was used since we did construct TSFE with a fixed page UID "1".
Now that we fall back to the first site configuration we must make sure URLs for that site's pages are absolute. After all, we cannot know in which context search results will be rendered in the end.
This ensures that all internal logic in TypoScriptFrontendController uses the same request attributes.
mbrodala
force-pushed
the
typo3v10-links-site
branch
from
eba585b to
54cd371
Compare
mbrodala
force-pushed
the
typo3v10-links-site
branch
from
8e983fe to
812fc28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.