-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TYPO3v11 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
force-pushed
the
typo3v11
branch
2 times, most recently
from
June 21, 2022 09:22
3874ff1
to
bc9ce12
Compare
By default the request "routing" attribute contains a SiteRouteResult set by the SiteResolver middleware. This is normally replaced by PageArguments by the PageResolver middleware. Our UriBuilder middleware runs before that and we cannot change the order here since we need need to be run before the StaticRouteResolver which runs after the PageResolver middleware.
This fixes the following error: > Cannot unpack array with string keys See TYPO3/typo3@3456ae0
In some cases this could be a float value which will cause type errors if a slot uses an "int" type hint.
This can be used for a smooth migration from signal/slot to events. The signal dispatching will be dropped at some point. See https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.4/Deprecation-90625-ExtbaseSignalSlotDispatcher.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.