Update get-all-agents response format for GoCD 19.3.0+ #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpdans This looks good! Sorry for the delayed reply. |
|
@MPV thanks for the reply. I think it is already up-to-date - I've run a rebase and it says it already matches master. |
|
@bpdans I guess I'm referring to the "Conflicting files" ( |
|
Also, any reasons you didn't contribute this to the main repo, i.e. here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoCD 19.3.0 had a backwards-incompatible change to the Agent response object, changing agent environments from a list of strings (names) to a list of objects: https://api.gocd.org/19.3.0/#get-all-agents
This fix adds a minimal
AgentEnvironmenttype and updates the type of theEnvfield in theAgentstruct to[]AgentEnvironment.Also added
go.modandgo.sum.