Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scrolled download icon is displayed even if show_downloads: false is specified. #14

Open
fu-sen opened this issue Dec 6, 2020 · 1 comment
Labels

Comments

@fu-sen
Copy link

fu-sen commented Dec 6, 2020

Use this theme by setting _config.yml to:

show_downloads: false

The header disappears the download icon as expected:
スクリーンショット 2020-12-06 14 59 29

But when scrolling down, the header still shows the download icon:
スクリーンショット 2020-12-06 14 59 34

I referred to the template and noticed it:
/_layouts/default.html:

  <div class="current-section">
    <a href="#top">Scroll to top</a>
    <a href="{{ site.github.tar_url }}" class="tar">tar</a><a href="{{ site.github.zip_url }}" class="zip">zip</a><a href="" class="code">source code</a>
    <p class="name"></p>
  </div>

There is no {% if site.show_downloads%} and {% endif%}.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
yanpierchirino pushed a commit to yanpierchirino/time-machine that referenced this issue Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant