fix: [P4PU-687] Added feign custom logger #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe-LaManna
requested review from
oleksiybozhykntt,
antonioT90 and
a team
as code owners
antonioT90
requested changes
Nov 14, 2024
| log(configKey,"[FEIGN_CLIENT_REQUEST] ---> %s %s", request.httpMethod(), request.url()); | ||
| log(configKey,"[FEIGN_CLIENT_RESPONSE] <--- Status: %d, response reason: %s, elapsed time (%d ms), response: %s", status, response.reason(), elapsedTime, responseString); | ||
|
|
||
| return response.toBuilder().body(bodyData).build(); |
There was a problem hiding this comment.
why don't you just return the input response?
if you don't read the body, the buffer is still available to be read
src/main/resources/application.yml
Outdated
| @@ -59,6 +59,7 @@ rest-client: | |||
|
|
|||
| logging: | |||
| level: | |||
| it.gov.pagopa.arc.connector: DEBUG | |||
There was a problem hiding this comment.
make it configurable throught env var with default value desired
antonioT90
requested changes
Nov 14, 2024
src/main/resources/application.yml
Outdated
| @@ -59,6 +59,7 @@ rest-client: | |||
|
|
|||
| logging: | |||
| level: | |||
| it.gov.pagopa.arc.connector: \${CONNECTOR_LOGGING_LEVEL:DEBUG} | |||
There was a problem hiding this comment.
for logging levels, let's use a common prefix
Suggested change
| it.gov.pagopa.arc.connector: \${CONNECTOR_LOGGING_LEVEL:DEBUG} | |
| it.gov.pagopa.arc.connector: \${LOGGING_LEVEL_ARC_CONNECTOR:DEBUG} |
antonioT90
approved these changes
Nov 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: