feat: [P4PU-000] Promote to MAIN #181
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P4PU-738 update swagger with totalAmount field
* P4PU-739 update mapper * P4PU-739 updated tests * P4PU-739 fixed tests
P4PU-740 updated postman collection
<!--- Please always add a PR description as if nobody knows anything about the context these changes come from. --> <!--- Even if we are all from our internal team, we may not be on the same page. --> <!--- Write this PR as you were contributing to a public OSS project, where nobody knows you and you have to earn their trust. --> <!--- This will improve our projects in the long run! Thanks. --> #### List of Changes - Added field totalAmount on notice details <!--- Describe your changes in detail --> #### Motivation and Context <!--- Why is this change required? What problem does it solve? --> #### How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> #### Screenshots (if appropriate): #### Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) #### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly.
P4PU-750 updated swagger with payment notice details API
* P4PU-751 added DTO of GPD details * P4PU-751 added GPD rest client * P4PU-751 added stubs file * P4PU-751 added faker * P4PU-751 added tests * P4PU-751 fix PullPaymentRestClient
* P4PU-752 added mappers * P4PU-752 added fakers * P4PU-752 added tests
* P4PU-753 added custom exception * P4PU-753 added tests
* P4PU-755 added Controller method and service * P4PU-755 added tests
P4PU-756 added test postman API paymentNoticesDetails
<!--- Please always add a PR description as if nobody knows anything about the context these changes come from. --> <!--- Even if we are all from our internal team, we may not be on the same page. --> <!--- Write this PR as you were contributing to a public OSS project, where nobody knows you and you have to earn their trust. --> <!--- This will improve our projects in the long run! Thanks. --> #### List of Changes - added API PaymentNoticesDetails <!--- Describe your changes in detail --> #### Motivation and Context <!--- Why is this change required? What problem does it solve? --> #### How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> #### Screenshots (if appropriate): #### Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) #### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly.
Giuseppe-LaManna
requested review from
oleksiybozhykntt,
antonioT90 and
a team
as code owners
* P4PU-799 updated swagger with new response of payment-notice API * P4PU-799 updated mapper * P4PU-799 updated tests
<!--- Please always add a PR description as if nobody knows anything about the context these changes come from. --> <!--- Even if we are all from our internal team, we may not be on the same page. --> <!--- Write this PR as you were contributing to a public OSS project, where nobody knows you and you have to earn their trust. --> <!--- This will improve our projects in the long run! Thanks. --> #### List of Changes - updated swagger with new response of payment-notice API <!--- Describe your changes in detail --> #### Motivation and Context <!--- Why is this change required? What problem does it solve? --> #### How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> #### Screenshots (if appropriate): #### Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) #### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: