chore: P4PU-145 create feign client for biz-events service #5
Conversation
# Conflicts: # src/main/resources/application.yml
|
according to the recent handbook and versioning this PR can be marked with the semantic commit |
|
fix the sonar issues, please |
Giuseppe-LaManna
changed the title
| import it.gov.pagopa.arc.connector.bizevents.dto.BizEventsTransactionsListDTO; | ||
|
|
||
| public interface BizEventsConnector { | ||
| BizEventsTransactionsListDTO transactionsList(String fiscalCode, String continuationToken, int size); |
There was a problem hiding this comment.
may you change the method name into something verbish like 'getSomething'?
| }catch (FeignException e) { | ||
| bizEventsTransactionsListDTO = | ||
| BizEventsTransactionsListDTO | ||
| .builder() | ||
| .transactions(new ArrayList<>()) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
we lack logging (and related observability) here.
There was a problem hiding this comment.
plus: I don't like very much the "catch all status codes" mode. We could change to "catch the 404 or rethrow the exception", I find it more transparent as if any errors occurs we can see it.
Later we can think to catch the other status codes when we know what to do
src/test/resources/stub/mappings/bizEventsService/bizEvents_Get_TransactionsList_OK.json
Show resolved
Hide resolved
| "matches": "x_api_key([0-9]?)+" | ||
| }, | ||
| "x-fiscal-code": { | ||
| "matches": "DUMMY_FISCAL_CODE_DEFAULT" |
There was a problem hiding this comment.
we might call it ERROR instead of DEFAULT
# Conflicts: # build.gradle.kts # src/main/resources/application.yml
| @@ -61,6 +61,9 @@ microservice-chart: | |||
| APPLICATIONINSIGHTS_PREVIEW_PROFILER_ENABLED: "false" | |||
| ENABLE_AUDIT_APPENDER: "TRUE" | |||
|
|
|||
| externalConfigMapValues: | |||
There was a problem hiding this comment.
why externalConfigMapValues? do we have a config map defined in the infrastructure code?
There was a problem hiding this comment.
Whit this task @umbcoppolabottazzi will add the configMap https://pagopa.atlassian.net/jira/software/c/projects/P4PU/boards/592/backlog?selectedIssue=P4PU-189
|
List of Changes
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: