Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLS-25 - Assertion Signature Verification #32

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Conversation

alessio-cialini
Copy link
Contributor

@alessio-cialini alessio-cialini commented Apr 19, 2023

List of Changes

  • Retrieved IDP data in the assertion verification flow
  • Introduced assertion signature validation
  • Removed tag list exception from core
  • Added assertion instant timestamp conversion

Motivation and Context

Completed the assertion verification flow by adding the signature validation

How Has This Been Tested?

Added unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@alessio-cialini alessio-cialini merged commit 09dfd9c into core-sprint-3 Apr 20, 2023
This was referenced Apr 21, 2023
@alessio-cialini alessio-cialini deleted the SLS-25 branch April 27, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants