Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLS-30 #5

Merged
merged 4 commits into from
Apr 4, 2023
Merged

SLS-30 #5

merged 4 commits into from
Apr 4, 2023

Conversation

alessio-cialini
Copy link
Contributor

@alessio-cialini alessio-cialini commented Apr 3, 2023

List of Changes

Introduced style & coherency checks using spotless gradle plugin for java code style checks. Defined standard configuration involving google style format. (https://github.com/diffplug/spotless/tree/main/plugin-gradle)
Introduced nebula gradle lint plugin to validate gradle scripts and dependency usage (https://github.com/nebula-plugins/gradle-lint-plugin)
Introduced javac compile property to enable -Xlint warnings to property 'all' (apply all warning checks on compile)

Motivation and Context

Response to non-functional requirement involving style & coherency checks.

How Has This Been Tested?

Executed scripts involving lint checks, and execution of the related tasks to automatically apply fixes and formats

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-cialini alessio-cialini self-assigned this Apr 3, 2023
@alessio-cialini alessio-cialini marked this pull request as draft April 3, 2023 13:02
@alessio-cialini alessio-cialini marked this pull request as ready for review April 3, 2023 13:31
@alessio-cialini alessio-cialini requested a review from pp-ps April 3, 2023 14:08
@alessio-cialini alessio-cialini removed their assignment Apr 3, 2023
@alessio-cialini alessio-cialini merged commit 13ec743 into core-sprint-1 Apr 4, 2023
@alessio-cialini alessio-cialini deleted the SLS-30 branch April 4, 2023 08:05
This was referenced Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants