Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLS-34] Implemented configuration utility class based on Typesafe Config #57

Merged
merged 13 commits into from
May 9, 2023

Conversation

svariant
Copy link
Contributor

@svariant svariant commented May 9, 2023

List of Changes

  • Defined an utility class LollipopTypesafeConfig in the core module that implements Lightbend's Config library in the core module
  • Defined a sample that uses the class as configuration
  • Updated the general README

Motivation and Context

Issue SLS-34

How Has This Been Tested?

A sample that uses the configuration class has been created and tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant requested a review from alessio-cialini May 9, 2023 14:16
@github-actions
Copy link

github-actions bot commented May 9, 2023

There is no coverage information present for the Files changed

Total Project Coverage 90.9% 🍏

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alessio-cialini alessio-cialini merged commit 25f7351 into 1.0.0-RC1 May 9, 2023
@gioelemella gioelemella mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants