-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOAPPFD0-179] Add the first iteration of the automatic process to generate new Icon...tsx
and Pictogram…tsx
files.
#118
Merged
dmnplb
merged 20 commits into
main
from
IOAPPFD0-179-draft-automation-processing-icons-pictograms
Oct 30, 2023
Merged
[IOAPPFD0-179] Add the first iteration of the automatic process to generate new Icon...tsx
and Pictogram…tsx
files.
#118
dmnplb
merged 20 commits into
main
from
IOAPPFD0-179-draft-automation-processing-icons-pictograms
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
changed the title
[IOAPPFD0-179] Add the first iteration of the automatic process to generate new
[IOAPPFD0-179] Add the first iteration of the automatic process to generate new Oct 26, 2023
Icon...tsx
files.Icon...tsx
and Pictogram…tsx
files.
CrisTofani
approved these changes
Oct 30, 2023
dmnplb
deleted the
IOAPPFD0-179-draft-automation-processing-icons-pictograms
branch
October 30, 2023 16:41
dmnplb
added a commit
that referenced
this pull request
Nov 6, 2023
…123) > [!warning] > This PR depends on #118 ## Short description This PR adds more than 40 new pictograms (bleed variants included) to the existing pictogram set. All the pictograms are generated through the new `generateNewPictograms` process. ## List of changes proposed in this pull request - Add more than 40 new pictograms (`*.tsx` extension and relative `*.svg` original file) ### Preview <img src="https://github.com/pagopa/io-app-design-system/assets/1255491/f8a66d75-25e2-4790-aec0-99650972a2af" width="350" /> ## How to test 1. Launch the example app 2. Go to the **Pictograms** page
dmnplb
added a commit
that referenced
this pull request
Nov 6, 2023
> [!warning] > This PR depends on #118 ## Short description This PR adds more than 20 new icons to the existing icon set. All the icons are generated through the new `generateNewIcons` process. ## List of changes proposed in this pull request - Add more than 20 new icons (`*.tsx` extension and relative `*.svg` original file) ### Preview <img src="https://github.com/pagopa/io-app-design-system/assets/1255491/f1a399f5-66a3-43f6-9ecf-2184a2392aef" width="325" /> > [!note] > New icons are marked with a green dot ## How to test 1. Launch the example app 2. Go to the **Icons** page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the new
generateNewIcons.js
andgenerateNewPictograms.js
processes to greatly reduce the delivery time of new icons and pictograms. Starting from the exported SVG files from Figma, the new process automatically generates the correspondingIcon...tsx
orPictogram…tsx
files with all the changes that used to require manual correction.Warning
This is the first iteration of the script. A testing period is required before it can be considered bulletproof.
List of changes proposed in this pull request
generateNewIcons
processgenerateNewPictograms
processtimestamp.txt
file that will be updated each time the script is run.How to test
src/components/icons
folder$ node generateNewIcons.js
Icon.tsx
file and check the Icons page in the example app.or alternatively:
src/components/pictograms
folder$ node generateNewPictograms.js
Pictogram.tsx
file and check the Pictograms page in the example app.