Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPFD0-179] Add the first iteration of the automatic process to generate new Icon...tsx and Pictogram…tsx files. #118

Merged
merged 20 commits into from
Oct 30, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Oct 24, 2023

Short description

This PR adds the new generateNewIcons.js and generateNewPictograms.js processes to greatly reduce the delivery time of new icons and pictograms. Starting from the exported SVG files from Figma, the new process automatically generates the corresponding Icon...tsx or Pictogram…tsx files with all the changes that used to require manual correction.

Warning

This is the first iteration of the script. A testing period is required before it can be considered bulletproof.

List of changes proposed in this pull request

  • Add the new generateNewIcons process
  • Add the new generateNewPictograms process
  • Add new icons and pictograms generated through the processes
  • Add the new timestamp.txt file that will be updated each time the script is run.

How to test

  1. Go to the src/components/icons folder
  2. Launch the following command: $ node generateNewIcons.js
  3. If you want, try to add the new generated icons to the Icon.tsx file and check the Icons page in the example app.

or alternatively:

  1. Go to the src/components/pictograms folder
  2. Launch the following command: $ node generateNewPictograms.js
  3. If you want, try to add the new generated icons to the Pictogram.tsx file and check the Pictograms page in the example app.

@dmnplb dmnplb added the Assets label Oct 24, 2023
@dmnplb dmnplb requested review from a team as code owners October 24, 2023 15:59
@dmnplb dmnplb marked this pull request as draft October 26, 2023 12:28
@dmnplb dmnplb changed the title [IOAPPFD0-179] Add the first iteration of the automatic process to generate new Icon...tsx files. [IOAPPFD0-179] Add the first iteration of the automatic process to generate new Icon...tsx and Pictogram…tsx files. Oct 26, 2023
@dmnplb dmnplb marked this pull request as ready for review October 27, 2023 15:01
@dmnplb dmnplb merged commit ffa6559 into main Oct 30, 2023
2 checks passed
@dmnplb dmnplb deleted the IOAPPFD0-179-draft-automation-processing-icons-pictograms branch October 30, 2023 16:41
dmnplb added a commit that referenced this pull request Nov 6, 2023
…123)

> [!warning]
> This PR depends on #118 

## Short description
This PR adds more than 40 new pictograms (bleed variants included) to
the existing pictogram set. All the pictograms are generated through the
new `generateNewPictograms` process.

## List of changes proposed in this pull request
- Add more than 40 new pictograms (`*.tsx` extension and relative
`*.svg` original file)

### Preview
<img
src="https://github.com/pagopa/io-app-design-system/assets/1255491/f8a66d75-25e2-4790-aec0-99650972a2af"
width="350" />

## How to test
1. Launch the example app
2. Go to the **Pictograms** page
dmnplb added a commit that referenced this pull request Nov 6, 2023
> [!warning]
> This PR depends on #118 

## Short description
This PR adds more than 20 new icons to the existing icon set. All the
icons are generated through the new `generateNewIcons` process.

## List of changes proposed in this pull request
- Add more than 20 new icons (`*.tsx` extension and relative `*.svg`
original file)

### Preview
<img
src="https://github.com/pagopa/io-app-design-system/assets/1255491/f1a399f5-66a3-43f6-9ecf-2184a2392aef"
width="325" />

> [!note]
> New icons are marked with a green dot

## How to test
1. Launch the example app
2. Go to the **Icons** page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants